search

ngrunwald / ring-middleware-format

Ring middleware for parsing parameters and emitting responses in JSON or other formats
163 stars 49 forks source link

make-type-request-pred is looking for :content-type in the wrong place #17

Closed cap10morgan closed 11 years ago

cap10morgan commented 11 years ago

The make-type-request-pred function appears to be looking for a :content-type key in the top-level request map, but :content-type lives in the :headers map. This causes it to not properly decode JSON request bodies in our testing (and it starts working when we assoc {:content_type "application/json"} into the request map.

ngrunwald commented 11 years ago

This is strange, as the ring spec is quite clear about the fact that :content-type is a standard top-level key. It works fine with Jetty and Tomcat here. In what context are you testing this? In the meantime, I've added a fallback check on the header string key here 878f3c5db336be828020be9aa6d6292224b387b7 which cannot hurt anyway.

cap10morgan commented 11 years ago

You know, I can't remember the context in which we were running into this. I should have put that into the issue originally. Sounds like it'll be fixed now regardless. Thanks!