search

ngrunwald / ring-middleware-format

Ring middleware for parsing parameters and emitting responses in JSON or other formats
163 stars 49 forks source link

Fix transit with wrap-restful-response #26

Closed Deraen closed 9 years ago

Deraen commented 10 years ago

Hi,

I noticed that transit encoding doesn't work with wrap-restful-response.

The reason is that for some reason format-encoders references wrap-transjon-{json,msgpack}-response-middleware. I changed the code to use make-transit-encoder.

ikitommi commented 9 years ago

Can this be merged in? Is currently broken.

minimal commented 9 years ago

:+1: for this fix.

ikitommi commented 9 years ago

could this be merged in? really need this & don't want to maintain a custom fork.

Deraen commented 9 years ago

This is fixed in fork: https://github.com/metosin/ring-middleware-format

bobby commented 9 years ago

:+1: for merging and releasing this.

ngrunwald commented 9 years ago

squashed and merged, thanks!