search

ngrunwald / ring-middleware-format

Ring middleware for parsing parameters and emitting responses in JSON or other formats
163 stars 49 forks source link

Upgrade clj-yaml to version 0.5.3 #51

Closed tranchis closed 8 years ago

tranchis commented 8 years ago

I detected a conflict between ring-middleware-format and uap-clj, which uses the forked version 0.5.3 of clj-yaml.

Upgrading to this version of clj-yaml is fairly easy (keywordize is true by default as seen here) and also allows to get rid of the not-very-elegant binding that was mandatory when using version 0.4.0.

tranchis commented 8 years ago

I've tried checking what's going on in the Travis build but it's not working for me, it keeps loading and showing nothing. I'll recheck later, but lein test passed with no errors.

Deraen commented 8 years ago

New clj-yaml doesn't seem to support Java 1.6. I think dropping support for 1.6 is OK.

Deraen commented 8 years ago

Merged to master.

Deraen commented 8 years ago

Ugh, in fact circleci/clj-yaml is also unusable on JDK 1.7. This is just because they have build the lib with Java 1.8 without providing javac -target: https://github.com/circleci/clj-yaml/issues/7

As such, I'll have to revert this unless better alternative can be found.

Deraen commented 8 years ago

Problem was fixed in circleci/clj-yaml.