search

ngrunwald / ring-middleware-format

Ring middleware for parsing parameters and emitting responses in JSON or other formats
163 stars 49 forks source link

allow passing response-predicate to wrap-restful-format #60

Open ninjudd opened 8 years ago

ninjudd commented 8 years ago

I'm not sure if this is the best fix for it, but right now, there is no way to pass :predicate to wrap-restful-format, because it ends up getting passed to both wrap-restful-params and wrap-restful-response, which doesn't work.

In my case, I only need to pass a predicate to wrap-restful-response, so I made that wrap-format-response accept :response-predicate and prefer that over :predicate.

There's probably a better way to solve this issue. I'm open to suggestions.

CmdrDats commented 6 years ago

Just got bitten hard by this issue - LGTM please?

CmdrDats commented 6 years ago

The alternative is in format_params.clj:273, the dissoc should also get rid of :predicate because it's entirely not composable. The predicates would need to be per format since it uses them to determine if it should handle the request.

Deraen commented 6 years ago

@CmdrDats Check https://github.com/metosin/muuntaja