search

ngrx / core

Core functionality for the ngrx platform
MIT License
72 stars 25 forks source link

compile issue on rxjs@beta.8 and typescript@next #1

Closed hlobil closed 7 years ago

hlobil commented 8 years ago

4 export declare class SyncSubject extends Subject {



node_modules/@ngrx/core/SyncSubject.d.ts(4,22): error TS2415: Class 'SyncSubject<T>' incorrectly extends base class 'Subject<T>'.
  Types of property '_subscribe' are incompatible.
    Type '(subscriber: Subscriber<T>) => AnonymousSubscription | Function | void' is not assignable to type '(subscriber: Subscriber<T>) => Subscription'.
      Type 'AnonymousSubscription | Function | void' is not assignable to type 'Subscription'.
        Type 'AnonymousSubscription' is not assignable to type 'Subscription'.
          Property 'isUnsubscribed' is missing in type 'AnonymousSubscription'.
damsorian commented 8 years ago

The same issue....

petebacondarwin commented 8 years ago

This is due to a breaking change in `RxJS@5.0.0.-beta-8'. See https://github.com/ReactiveX/RxJS/commit/ba9ef2b#diff-c745ba5bcc0e744ecdcc572424f38498L3

svi3c commented 8 years ago

Is the dependency usage going to be updated soon? Angular 2 now depends on 5.0.0-beta.11 since this commit. Only ngrx is keeping me from updating my project dependency now.

EDIT: I just saw that this project now depends on 5.0.0-beta.11 as well. So this issue should be resolved now, right?

brandonroberts commented 7 years ago

Issue has been resolved with RxJS 5.x being released