ngrx / core

Core functionality for the ngrx platform
MIT License
72 stars 25 forks source link

turn on noImplicitAny #16

Closed timruffles closed 5 years ago

timruffles commented 7 years ago

Since this module is designed to be compiled by consumer projects (from what I can tell - see #15), it's nice to turn on noImplicitAny so those using noImplicitAny don't suffer compiler warnings.

The compose function had a signature, but tsc didn't seem to be able to infer its argument types so considers them implicitly any. I've added annotations, and checked that ComposeSignature is still the type consumers see.

I'm now using this commit in my project, and the compiler warnings have thankfully ceased 🎉

Fixes #15.

timruffles commented 5 years ago

Closing as project seems quiet.