search

ngrx / core

Core functionality for the ngrx platform
MIT License
72 stars 25 forks source link

chore: Upgrade build process to emit ESM modules and a UMD bundle #6

Closed MikeRyanDev closed 8 years ago

MikeRyanDev commented 8 years ago

@brandonroberts I'm worried that deep import paths will break for users now that the module format has been switched to ESM. Example:

import { compose } from '@ngrx/core/compose';

Thinking this should be released as v2.0 and all dependents should accept a semver range of ^1.0.0 || ^2.0.0

brandonroberts commented 8 years ago

LGTM. The import update should be noted as a breaking change.

NathanWalker commented 8 years ago

@MikeRyan52 Curious on merge status if you don't mind me asking? That core peerDep issue is tough with rc.7 at moment ;)

MikeRyanDev commented 8 years ago

Augmented the build to include legacy CJS output. Imports like @ngrx/core/add/operator/select will continue to work.

MikeRyanDev commented 8 years ago

Published as v1.2.0

cc @NathanWalker

NathanWalker commented 8 years ago

I'm dancing. Like. actually... dancing. Thank you @MikeRyan52 !!