ngrx / platform

Reactive State for Angular
https://ngrx.io
Other
7.96k stars 1.95k forks source link

feat(effects): add migrator for `concatLatestFrom` #4311

Closed rainerhahnekamp closed 2 months ago

rainerhahnekamp commented 2 months ago

Adds a migrator for version 18 which replaces all concatLatestFrom imports from @ngrx/effects to @ngrx/operators.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

Migration to @ngrx/operators

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Closes #4262

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

netlify[bot] commented 2 months ago

Deploy Preview for ngrx-io canceled.

Built without sensitive environment variables

Name Link
Latest commit d684d778be880e6c80e0f446d1a66ae7ef7f856d
Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/663a9651e544d60008961d11
rainerhahnekamp commented 2 months ago

@markostanimirovic I'd suggest we make this one first and it will serve as a template for the component-store migrator

rainerhahnekamp commented 2 months ago

@markostanimirovic if possible, I'd like to push the version that includes the fix of https://github.com/ngrx/platform/pull/4311#discussion_r1589989821 before this is merged.

markostanimirovic commented 2 months ago

@markostanimirovic if possible, I'd like to push the version that includes the fix of #4311 (comment) before this is merged.

sounds good!