ngrx / platform

Reactive State for Angular
https://ngrx.io
Other
8.01k stars 1.97k forks source link

fix(router-store): include string[] as return type for selectQueryParam #4369

Closed timdeschryver closed 4 months ago

timdeschryver commented 4 months ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #4286

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No
BREAKING CHANGE:

BEFORE:
The return type of `selectQueryParam` is `MemoizedSelector<V, string | undefined>`.

AFTER:
The return type of `selectQueryParam` now includes `string[]`, making the return type `MemoizedSelector<V, string | string[] | undefined>`.

Other information

netlify[bot] commented 4 months ago

Deploy Preview for ngrx-io ready!

Name Link
Latest commit 5841e171a70a530d11619510a3f012052b0396e6
Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/6659c8a7cb91450008582c4a
Deploy Preview https://deploy-preview-4369--ngrx-io.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.