fix(effects): fix bugs in migration script to v18

rainerhahnekamp commented 3 weeks ago

ChangeLog:

Update 17.6: Remove os.EOL.

This commit fixes one major bug and some edge cases in the migration script.

Reset the changes array with every file.
Fix an issue when a file has multiple import declarations to @ngrx/effects.
Print out a warning if concatLatestFrom is imported multiple times.

The same problem exists for the component store's migration script. I will provide a PR for that as well.

I'm afraid a new patch release is necessary. Apologies, I'm very sorry!

PR Checklist

Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/ngrx/platform/blob/main/CONTRIBUTING.md#commit
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Documentation has been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[] Other... Please describe:

Closes #4397

Does this PR introduce a breaking change?

[] Yes
[x] No

Other information

netlify[bot] commented 3 weeks ago

Deploy Preview for ngrx-io ready!

Name	Link
Latest commit	5c211d6b253225157d216677e7fd35b4d89f93dc
Latest deploy log	https://app.netlify.com/sites/ngrx-io/deploys/6671dce8606c180008177140
Deploy Preview	https://deploy-preview-4402--ngrx-io.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rainerhahnekamp commented 2 weeks ago

@timdeschryver I've applied the requested changes. I will do the same for the PR regarding the component store.

ngrx / platform