search

ngrx / platform

Reactive State for Angular
https://ngrx.io
Other
7.96k stars 1.95k forks source link

@ngrx/component-store@18.0.0 dependency check fails with ng-recaptcha@latest #4407

Closed morsagmon closed 2 weeks ago

morsagmon commented 2 weeks ago

Which @ngrx/* package(s) are the source of the bug?

component-store

Minimal reproduction of the bug/regression with instructions

Run: npm i @ngrx/component-store@18.0.0 into an Angular 18.0.1 project where ng-recaptcha@13.2.1 (latest) is installed.

Expected behavior

The upgrade installation fails on dependency check.

Versions of NgRx, Angular, Node, affected browser(s) and operating system(s)

Windows 10. Angular 18.0.1 Installed @ngrx/component-store: 17.1.1

Other information

Dependency check error:

npm i @ngrx/component-store@18.0.0
npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: ng-recaptcha@13.2.1
npm error Found: @angular/core@18.0.1
npm error node_modules/@angular/core
npm error   peer @angular/core@"18.0.1" from @angular/animations@18.0.1
npm error   node_modules/@angular/animations
npm error     peerOptional @angular/animations@"18.0.1" from @angular/platform-browser@18.0.1
npm error     node_modules/@angular/platform-browser
npm error       peer @angular/platform-browser@"18.0.1" from @angular/forms@18.0.1
npm error       node_modules/@angular/forms
npm error         @angular/forms@"^18.0.1" from the root project
npm error       3 more (@angular/platform-browser-dynamic, @angular/router, the root project)
npm error     @angular/animations@"^18.0.1" from the root project
npm error   peer @angular/core@"18.0.1" from @angular/common@18.0.1
npm error   node_modules/@angular/common
npm error     peer @angular/common@"18.0.1" from @angular/forms@18.0.1
npm error     node_modules/@angular/forms
npm error       @angular/forms@"^18.0.1" from the root project
npm error     peer @angular/common@"18.0.1" from @angular/platform-browser@18.0.1
npm error     node_modules/@angular/platform-browser
npm error       peer @angular/platform-browser@"18.0.1" from @angular/forms@18.0.1
npm error       node_modules/@angular/forms
npm error         @angular/forms@"^18.0.1" from the root project
npm error       3 more (@angular/platform-browser-dynamic, @angular/router, the root project)
npm error     4 more (@angular/platform-browser-dynamic, @angular/router, ...)
npm error   8 more (@angular/compiler, @angular/forms, ...)
npm error
npm error Could not resolve dependency:
npm error peer @angular/core@"^17.0.0" from ng-recaptcha@13.2.1
npm error node_modules/ng-recaptcha
npm error   ng-recaptcha@"^13.2.1" from the root project
npm error
npm error Conflicting peer dependency: @angular/core@17.3.11
npm error node_modules/@angular/core
npm error   peer @angular/core@"^17.0.0" from ng-recaptcha@13.2.1
npm error   node_modules/ng-recaptcha
npm error     ng-recaptcha@"^13.2.1" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.

package.json file:

{
  "name": "my-dream-team",
  "version": "0.0.1",
  "scripts": {
    "ng": "ng",
    "start": "ng serve",
    "build": "ng build",
    "watch": "ng build --watch --configuration development",
    "test": "ng test"
  },
  "private": true,
  "dependencies": {
    "@angular/animations": "^18.0.1",
    "@angular/common": "^18.0.1",
    "@angular/compiler": "^18.0.1",
    "@angular/core": "^18.0.1",
    "@angular/forms": "^18.0.1",
    "@angular/platform-browser": "^18.0.1",
    "@angular/platform-browser-dynamic": "^18.0.1",
    "@angular/router": "^18.0.1",
    "@ngrx/component-store": "^17.1.1",
    "google-libphonenumber": "^3.2.33",
    "js-sha256": "^0.10.1",
    "ng-recaptcha": "^13.2.1",
    "ngx-cookie-service": "^17.1.0",
    "ngx-pixel-eventid": "^1.1.2",
    "primeflex": "^3.3.1",
    "primeicons": "^7.0.0",
    "primeng": "^17.12.0",
    "rxjs": "~7.8.0",
    "socket.io-client": "^4.7.2",
    "tslib": "^2.3.0",
    "wavesurfer.js": "^7.5.4",
    "zone.js": "~0.14.2"
  },
  "devDependencies": {
    "@angular-devkit/build-angular": "^18.0.2",
    "@angular/cli": "^18.0.2",
    "@angular/compiler-cli": "^18.0.1",
    "@types/bcryptjs": "^2.4.6",
    "@types/google-libphonenumber": "^7.4.30",
    "@types/jasmine": "~5.1.0",
    "jasmine-core": "~5.1.0",
    "karma": "~6.4.0",
    "karma-chrome-launcher": "~3.2.0",
    "karma-coverage": "~2.2.0",
    "karma-jasmine": "~5.1.0",
    "karma-jasmine-html-reporter": "~2.1.0",
    "typescript": "~5.4.5"
  }
}

I would be willing to submit a PR to fix this issue

rainerhahnekamp commented 2 weeks ago

That issue is not related to NgRx.

ng-recaptcha has a dependency to Angular 17. Please file an issue at https://github.com/DethAriel/ng-recaptcha.

npm i @ngrx/component-store@18.0.0 just triggered the internal "versioning verification".