ngrx / store-devtools

Developer Tools for @ngrx/store
MIT License
325 stars 38 forks source link

enable sourcemaps? #29

Closed rweng closed 8 years ago

rweng commented 8 years ago

Hi there,

I'd like to discuss if we should enable sourcemaps in the tsconfig.json. Reason: When I had an error in one of my reducers. The error was obscured by store-devtools, which (loggs out the error)[https://github.com/ngrx/store-devtools/blob/master/src/reducer.ts#L37], but it seems when sourcemaps are not enabled chrome has problems detecting the sourcemaps of files further up the stack. I found this issue in Chrome.

Anyhow, it could be that my webpack configuration is the problem, but when I checked out the projected in build it w/ sourcemaps enabled it got better errors. What's your take on this? Any reasons not to ship sourcemaps?

Thanks, Robin

Edit: Setting the webpack config to devtool: 'source-map' solves the problem, so feel free to close the issue if you consider it irrelevant (I leave it open since I'd like to know your thoughts on why sourcemaps are disabled)

MikeRyanDev commented 8 years ago

Fixed in v3.0.2