search

ngrx / store-devtools

Developer Tools for @ngrx/store
MIT License
325 stars 38 forks source link

WIP: include init action in log #4

Closed laurelnaiad closed 8 years ago

laurelnaiad commented 8 years ago

All that works now as I'd expect, though I don't know if its 100% what the redux version does.

TODO: tests

@MikeRyan52 @robwormald -- I'd like to add tests for LogMonitor. Do you have a preferred strategy for a loader that would get the code into Karma? Left to my own devices, I'd be using jspm (EDIT: or at least systemjs) because that's what I know, but I think neither of you want to see that. @robwormald I know you're interested in stealjs. Is now the time to figure that out? @MikeRyan52 what would you do? Should we test the dist directory and thus avoid transpile issues within the tests?

laurelnaiad commented 8 years ago

P.S. Thoughts on phantomjs2 as a dev dependency? Sauce?

laurelnaiad commented 8 years ago

Shoot... just noticed a double double quote in the template. Will fix that.

robwormald commented 8 years ago

We run on codeship for CI, pretty sure it has chrome available. More real world than phantom.

MikeRyanDev commented 8 years ago

We actually need a more robust build process overall (producing es6 artifacts, only publishing the dist folder, etc). I wouldn't worry about building this infrastructure in your current PR.

robwormald commented 8 years ago

Though if you do want browser testing, there's a karma setup here you can copy https://github.com/ngrx/db On Sun, Mar 13, 2016 at 1:37 PM Mike Ryan notifications@github.com wrote:

We actually need a more robust build process overall (producing es6 artifacts, only publishing the dist folder, etc). I wouldn't worry about building this infrastructure in your current PR.

— Reply to this email directly or view it on GitHub https://github.com/ngrx/devtools/pull/4#issuecomment-196047741.

laurelnaiad commented 8 years ago

Ok. When I set out to write some unit tests for the component, I hadn't even realized that the existing tests weren't running under phantom and thus there was a dearth of infrastructure on which to write the tests. I'm closing this in favor of https://github.com/ngrx/devtools/pull/7 which has the double quotes fix and I think is good to go.

laurelnaiad commented 8 years ago

@robwormald thank you for pointing out the db repo! That will come in very handy.