ngrx / store-devtools

Developer Tools for @ngrx/store
MIT License
326 stars 38 forks source link

performance is slow when dealing with large data set #45

Closed born2net closed 7 years ago

born2net commented 7 years ago

We have a large data set, about 11,000+ records, and we see major slow down in the application when the Redux devtool is enabled.

As soon as we disabled it, all is great and fast again.

// StoreDevtoolsModule.instrumentOnlyWithExtension(),

If this is a challenging fix, I would like to be able to pause / mute the extension and only activate it when I need it. This way we will not have to manually mark and unmark all the time in the source code:

StoreDevtoolsModule.instrumentOnlyWithExtension(),

already set the history to 5. if any other recommendation on optimization, will be glad to test,

now it could very well be that the bug is really with the chrome extension itself and not the ngrx side of things....

so I did further testing and this is definitely an issue when dealing with a data set of 11,000+ items. I also want to note that if you click the commit button, things will works just fine for a few more iterations. So maybe the history of the commit is what is causing the slowness? Is there a way to simply auto commit after every store update while in development mode?

I created a video of the issue: https://dl.dropboxusercontent.com/u/93017334/ReduxDev.mp4

Regards,

Sean

born2net commented 7 years ago

this while not entirely fix it, does make the issue a non issue (requires a lot of effort to make it hang now) good enough:

StoreDevtoolsModule.instrumentStore({
            maxAge: 2,
        }),