ngryman / gulp-bro

:punch: gulp + browserify + incremental build, done right.
MIT License
122 stars 13 forks source link

update browserify to version 16 #60

Closed khalyomede closed 4 years ago

khalyomede commented 4 years ago

Could you update your package.json (if it is enough?) browserify version to 16, in order to be able to use split-require with your gulp plugin please?

ngryman commented 4 years ago

Hey @khalyomede ,

I've upgraded all dependencies (including browserify). Would mind giving it a try before I officially publish it?

To test, you can modify your package.json like this:

{
  "devDependencies": {
    "gulp-bro": "ngryman/gulp-bro#bump/all-deps"
  }
}

Let me know if it works.

khalyomede commented 4 years ago

Hi @ngryman, it works at the perfection :) I checked by seeing if split-require worked (and as my SPA is heavily using dynamic import, I also checked if it still works to navigate between pages).

So for now all good! Thank you 👍

ngryman commented 4 years ago

@khalyomede Alright, happy it works as expected. I've just released 2.0.0 so you can change your dependency back to semver if you want.