ngs-doo / revenj

DSL Platform compatible backend
https://dsl-platform.com
BSD 3-Clause "New" or "Revised" License
268 stars 44 forks source link

Autofac services order #163

Closed Kobus-Smit closed 3 years ago

Kobus-Smit commented 3 years ago

Hi @zapov

I had a look at https://github.com/ngs-doo/revenj/issues/162 and looks like it is because of Autofac service order, see https://github.com/aspnet/KestrelHttpServer/issues/923.

This PR merged the changes from https://github.com/autofac/Autofac/commit/6c7f377d6bc279d62ee16f206690563a856e0313 and now Revenj starts in my .NET 5 Kestrel service.

Can you please check if these changes are acceptable or suggest otherwise?

zapov commented 3 years ago

Tnx. I'll take a look in next few days

zapov commented 3 years ago

Tnx for the PR Test suite still works.

I've merged the commit, but I'll close this since Github does not recognize merge.

Its cute how MS forces everyone to work around their design flaws (I've read the related drama) :expressionless:

Kobus-Smit commented 3 years ago

Yep. Thanks mate.

Do you have a rough ETA when the NuGet will be published?