search

ngs-doo / revenj

DSL Platform compatible backend
https://dsl-platform.com
BSD 3-Clause "New" or "Revised" License
268 stars 44 forks source link

Ctrl+C hangs Revenj Kestrel #165

Closed Kobus-Smit closed 3 years ago

Kobus-Smit commented 3 years ago

Hi @zapov

I've deployed a Windows service with Revenj.AspNetCore 1.6 and Kestrel and noticed it hangs when stopping the service.

I could then also replicate it by running AspNetTutorialLite from Visual Studio and pressing Ctrl+C.

Application is shutting down... but the process is not killed.

image

It appears only to happen if a Revenj service method was called, for example if you comment launchBrowser

https://github.com/Kobus-Smit/revenj-examples/blob/75d6543f142d81a0483d1db74d9a6f656b3b8485/DotNetCore/netcoreapp3.1/AspNetTutorialLite/Properties/launchSettings.json#L22

and run and Ctrl+C, then it works as expected: image

Do you perhaps have any ideas or workarounds?

zapov commented 3 years ago

It seems Thread.Abort() no longer works :/

Replaced its usage in the DB driver so it seems fine. It would be great if you can test out the latest version before I make a new release

Kobus-Smit commented 3 years ago

LGTM!

image