search

ngs-doo / revenj

DSL Platform compatible backend
https://dsl-platform.com
BSD 3-Clause "New" or "Revised" License
268 stars 44 forks source link

Add offset to bar chart #166

Closed mskalnik closed 3 years ago

mskalnik commented 3 years ago

Bar chart has offset defined as true by default to true but it was overridden here. Having it as false results in the column with the lowest value not displaying for graphs with relative values since it's value will be used as the starting point while rendering.

zapov commented 3 years ago

I'll merge this, but this looks really weird. What if its any other type?

mskalnik commented 3 years ago

It will be false for every other type to keep consistent with the original behavior. The documentations says the default is false and adds this in the description:

If true, grid lines will be shifted to be between labels. This is set to true for a bar chart by default.