search

ngs-lang / ngs

Next Generation Shell (NGS)
https://ngs-lang.org/
GNU General Public License v3.0
1.46k stars 41 forks source link

Issue #492 - MacOS man #503

Closed organom closed 2 years ago

organom commented 2 years ago

MacOS man by default is stored in /usr/local/shared/man/man1 instead of /usr/local/man/man1

organom commented 2 years ago

@ilyash can you please also try the install both in your mac and linux in order to make sure everything works correctly? thanks :)

ilyash commented 2 years ago

@ilyash can you please also try the install both in your mac and linux in order to make sure everything works correctly? thanks :)

As agreed during the weekly, please add tests so that correct installation is tested during/after the build on GitHub

organom commented 2 years ago

@ilyash-b added the tests directly in the makefile at https://github.com/ngs-lang/ngs/pull/503/commits/b40e7988d6d704f539b897f788591a3ef7388403. Do you have any better idea, or is it ok like this?

Also noticed that this is breaking the docker build, since apparently inside docker:

root@1ecc278a0218:/# man ls
This system has been minimized by removing packages and content that are
not required on a system that users do not log into.

To restore this content, including manpages, you can run the 'unminimize'
command. You will still need to ensure the 'man-db' package is installed.

Any idea for this?

organom commented 2 years ago

Man test added to be build, after merge of this, we need to re-adapt PR #524 @ilyash is it ok like this? or we need something else to approve this one ?

organom commented 2 years ago

@ilyash-b changes applied, please re-review