ngs-lang / ngs

Next Generation Shell (NGS)
https://ngs-lang.org/
GNU General Public License v3.0
1.4k stars 43 forks source link

Add extra build action for arm #538

Closed organom closed 2 years ago

organom commented 2 years ago

Based on #535

organom commented 2 years ago

@ilyash on arm I'm getting a failure on the test:

Issue

1: + Test: time() > 1466662171
1: [ERROR 1954-01-22 19:17:14 UTC] +--------------------------------------------------+
1: [ERROR 1954-01-22 19:17:14 UTC] | Test failed: time() > 1466662171. Returned false |
1: [ERROR 1954-01-22 19:17:14 UTC] +--------------------------------------------------+
1: [ERROR 1954-01-22 19:17:14 UTC] Exception of type Error occurred
1: [ERROR 1954-01-22 19:17:14 UTC] Frame 0: <builtin-stdlib>:8087:2 - 8087:35
1: [ERROR 1954-01-22 19:17:14 UTC] Frame 1: <builtin-stdlib>:8061:21 - 8061:30 [in bootstrap_exception_catch_wrapper]
1: [ERROR 1954-01-22 19:17:14 UTC] Frame 2: <builtin-stdlib>:7993:12 - 7993:24 [in bootstrap]
1: [ERROR 1954-01-22 19:17:14 UTC] Frame 3: /ngs/test.ngs:37:7 - 37:11
1: [ERROR 1954-01-22 19:17:14 UTC] Frame 4: <builtin-stdlib>:2392:11 - 2392:13 [in each]
1: [ERROR 1954-01-22 19:17:14 UTC] Frame 5: /ngs/test.ngs:18:13 - 18:18 [in perform_tests_in_file]
1: [ERROR 1954-01-22 19:17:14 UTC] Frame 6: <builtin-stdlib>:5557:2 - 5557:9 [in lines]
1: [ERROR 1954-01-22 19:17:14 UTC] Frame 7: <builtin-stdlib>:2173:8 - 2173:14 [in finally]
1: [ERROR 1954-01-22 19:17:14 UTC] Frame 8: <builtin-stdlib>:3731:11 - 3731:14 [in Result]
1: [ERROR 1954-01-22 19:17:14 UTC] Frame 9: <builtin-stdlib>:5559:16 - 5559:21
1: [ERROR 1954-01-22 19:17:14 UTC] Frame 10: <builtin-stdlib>:4354:12 - 4354:16 [in lines]
1: [ERROR 1954-01-22 19:17:14 UTC] Frame 11: <builtin-stdlib>:2392:11 - 2392:13 [in each]
1: [ERROR 1954-01-22 19:17:14 UTC] Frame 12: /ngs/test.ngs:25:4 - 25:16
1: [ERROR 1954-01-22 19:17:14 UTC] Frame 13: /ngs/test.ngs:12:59 - 12:64 [in perform_test]

When running ngs -pi "time()" I get <Int -503036595>

How to reproduce

From inside your local root folder of ngs, run: docker run -it --volume "${PWD}:/ngs" ghcr.io/ngs-lang/ngs/run-on-arch-ngs-lang-ngs-build-armv7-bullseye:latest

then

cd /ngs
./install.sh
(cd build && ctest -VV)
ngs -pi "time()"

Any idea?

ilyash-b commented 2 years ago

@organom , suspect number one:

Should potentially be solved if https://github.com/ngs-lang/ngs/issues/65 is done

organom commented 2 years ago

tested with aarch64 and it works image

Run as docker run -it --volume "${PWD}:/ngs" ghcr.io/ngs-lang/ngs/run-on-arch-ngs-lang-ngs-build-aarch64-bullseye:latest

Does this mean intel 32 will also not work?

ilyash-b commented 2 years ago

99% sure any 32 bit will not work

organom commented 2 years ago

image

Tested with different 64 bit architectures and they are working great

About the 32 bits ones, are we going to support them? or should we just stay with 64 bits for now ?

ilyash-b commented 2 years ago

I'd leave 32 bit out for now. We can look into that if there will be demand from users.

organom commented 2 years ago

merged