search

ngscopeclient / scopehal-apps

ngscopeclient and other client applications for libscopehal.
https://www.ngscopeclient.org/
BSD 3-Clause "New" or "Revised" License
614 stars 104 forks source link

When cycling back through the history, trigger point and channel are not updated #361

Open mubes opened 3 years ago

mubes commented 3 years ago

Steps to reproduce; Record waveform A using trigger x, Record waveform B using trigger y. Use history to go back to waveform A, trigger y is still displayed.

azonenberg commented 3 years ago

All scope settings (vertical scale, trigger configuration, etc) are displayed at their current values. Historical waveforms only store sample data, not a full snapshot of scope settings.

602p commented 2 years ago

Having a snapshot of scope settings would be useful for me. We should maybe think generally about how to save scope setup information like this in historical waveforms. Function generator state will be another thing like this, since it would be nice to be able to e.g. characterize a filter at a range of inputs and save the whole thing as a .scopesession that includes the input func gen settings for each capture too.

This issue, #283, #343, #360 in my mind form kind of a feature bundle that would allow a scopesession to be "notebook-like" in containing labeled captures with their at-capture scope configs. Maybe open tracker ticket for that if that jives with your vision?

azonenberg commented 2 years ago

Yes, I think that would be useful. Go ahead and file a ticket for that.