GitHub Windows CI Build issue step "Test" and step "Build MSI / portable zip"

[bvernoux]

To investigate on why the GitHub Windows CI Build fail to run the exe (step Test) I have disabled this test to continue build until end and check the generated files

• See https://github.com/bvernoux/scopehal-apps/actions/runs/3048002706

  • glscopeclient-windows-portable.zip does not have all required DLLs and some DLLs are missing when we execute glscopeclient.exe from the directory (which could explain why the GitHub Windows CI Build fail to run the exe)

• This issue could be related to -DCMAKE_BUILD_TYPE=Release (before it was not set so by default it was implicitly set to Debug) was added in step Build MSI / portable zip

  • @someone--else & @umarcor to be clarified what is running behind the step Build MSI / portable zip and how to fix it
  • See https://github.com/glscopeclient/scopehal-apps/blob/master/.github/workflows/build-windows.yml
  • See https://github.com/glscopeclient/scopehal-apps/blob/master/msys2/PKGBUILD
  • See https://github.com/glscopeclient/scopehal-apps/blob/master/src/glscopeclient/CMakeLists.txt#L146
  • See https://github.com/glscopeclient/scopehal-apps/blob/master/src/glscopeclient/wix/glscopeclient.wxs.in

[bvernoux]

Issue fixed with https://github.com/glscopeclient/scopehal-apps/pull/494