search

ngscopeclient / scopehal-apps

ngscopeclient and other client applications for libscopehal.
https://www.ngscopeclient.org/
BSD 3-Clause "New" or "Revised" License
604 stars 99 forks source link

ngscopeclient Fix crash on Instrument empty nickname #500

Closed bvernoux closed 2 years ago

azonenberg commented 2 years ago

Empty nicknames should not be possible, adding this check to every single place we use the nickname would be a huge amount of work and turn into constant whack-a-mole.

Better to add error detection when loading recent instruments and connecting to devices to reject any attempt to supply an empty name.

bvernoux commented 2 years ago

Yes it will be better to catch that as early as possible. Code proposal (tested and working)