ngscopeclient / scopehal-apps

ngscopeclient and other client applications for libscopehal.
https://www.ngscopeclient.org/
BSD 3-Clause "New" or "Revised" License
535 stars 83 forks source link

ngscopeclient Windows / Linux(Ubuntu 23.04) big slow down on some zoom step #590

Closed bvernoux closed 1 year ago

bvernoux commented 1 year ago

Tested with ngscopeclient 0.1-https://github.com/glscopeclient/scopehal-apps/commit/e2617799fdf28b9984db4b87c7b2ac3224e2e3c5 (Commit 25 May 2023) PC used:

OS tested:

Data used see CH569_SerDes_180Mbps_data_scopesession.zip

Big slow down on some zoom steps when using CH569_SerDes_180Mbps_data_scopesession.zip

ngscopeclient.exe
File => Open Offline... => D:\glscopeclient\CH569_SerDes_180Mbps.scopesession
At certain zoom level everything is slow, there is exactly 2 zoom steps which reproduce that issue systematically, see screenshots on different OS

Screenshot of the issue on Windows11 Pro Ryzen 9 7950X3D/RTX4070 we see rasterize time and tone map time exceed 200ms (and even more)

Note1: Everything is dead slow on Windows11 Pro even outside ngscopeclient Note2: For other zoom steps everything is perfect rasterize time and tone map time < 1ms

1st zoom step which reproduce the issue image

2nd zoom step (just +1) which reproduce the issue image

Screenshot of the issue on Linux(Ubuntu 23.04) Ryzen 9 7950X3D/RTX4070 we see rasterize time exceed 200ms (and even more)

Note1: Everything is dead slow on Ubuntu 23.04 even outside ngscopeclient Note2: For other zoom step everything is perfect rasterize time and tone map time < 1ms

image

bvernoux commented 1 year ago

Tested with latest ngscopeclient commit https://github.com/glscopeclient/scopehal-apps/commit/fd4fa0d0de3e3173b8fdb22a0b01041e9830a4d9 and the issue is reproducible (tested only on Win11 Pro need to test on Ubuntu23.04)

1st zoom step huge slow down (race condition ?)

image

2nd zoom step huge slow down (race condition ?)

image

For Reference other step no slow down everything work fine 60fps

image

bvernoux commented 1 year ago

Issue fixed with commit https://github.com/glscopeclient/scopehal-apps/commit/2f4cf45ecabc29bc13efdab15c92856412601fd4