search

ngscopeclient / scopehal-apps

ngscopeclient and other client applications for libscopehal.
https://www.ngscopeclient.org/
BSD 3-Clause "New" or "Revised" License
535 stars 83 forks source link

Fix glscopeclient Windows zip/MSI missing dependencies Create ngscopeclient msi/portable zip/install #595

Closed bvernoux closed 1 year ago

bvernoux commented 1 year ago

GitHub CI build done with success https://github.com/bvernoux/scopehal-apps/actions/runs/5223643928

Johnsel commented 1 year ago

Testing, does GitHub do the zipping or we?

bvernoux commented 1 year ago

Testing, does GitHub do the zipping or we?

GitHub do all But I have seen an issue build\dist\glscopeclient_windows_x64\shaders have some missing shaders => all waveform- shaders are missing build\dist\ngscopeclient_windows_x64\shaders have some missing shaders => all waveform- shaders are missing This is not a new issue in fact it was already present and it shall be fixed it seems like some dependencies to generate the missing shaders are not executed at the right time and those files are not present during the install ...

In conclusion actual issue is: Final Windows portable zip/MSI installer build have missing shaders which prevent to use demo or display any waveform in fact

Johnsel commented 1 year ago

Maybe it's the GH action, I'll take a look. Yes ngscopeclient msi install crashed. I didn't test further since you seem to be on it already.

bvernoux commented 1 year ago

Maybe it's the GH action, I'll take a look. Yes ngscopeclient msi install crashed. I didn't test further since you seem to be on it already.

Yes you have probably that error (when glscopeclient or ngscopeclient is launched with --debug) when you want to display some waveform: Warning: ReadDataFile: Could not open file "shaders/waveform-compute.analog.int64.dense.spv" terminate called after throwing an instance of 'vk::UnknownError' what(): vkCreateShaderModule: ErrorUnknown

It is affected by an old issue never solved https://github.com/glscopeclient/scopehal-apps/issues/505

bvernoux commented 1 year ago

The issue https://github.com/glscopeclient/scopehal-apps/issues/505 is solved by my latest commit https://github.com/glscopeclient/scopehal-apps/commit/335945e1990297b80d6bec0806f267d123d47638 The PR can be merged everything is good now You can check/test on Windows the results zip / install for both ngscopeclient & glscopeclient with all dependencies/shader ... in https://hydrabus.com/scopehal-apps/

Build finished with success on GitHub CI https://github.com/bvernoux/scopehal-apps/actions/runs/5224876669