search

ngscopeclient / scopehal-apps

ngscopeclient and other client applications for libscopehal.
https://www.ngscopeclient.org/
BSD 3-Clause "New" or "Revised" License
535 stars 83 forks source link

Attempting to add multiple instruments at the same time breaks pop-up/input fields #615

Closed Johnsel closed 9 months ago

Johnsel commented 9 months ago

To replicate my issue use the Add->Generator->Connect menu, then click Add->Oscilloscope->Connect, without first adding the Generator.

This will make the Add Function Generator pop-up contain 2 sets of input fields, but they are broken.

image

azonenberg commented 9 months ago

Easy fix, use unique imgui ID for all "add XX" dialogs. I don't think any other code actually relies on these being single instance dialogs.

Will work on this later today.