ngscopeclient / scopehal-apps

ngscopeclient and other client applications for libscopehal.
https://www.ngscopeclient.org/
BSD 3-Clause "New" or "Revised" License
616 stars 104 forks source link

RFE: be able to numerically view and edit instrument parameters from Waveform Group screen #760

Closed jwise closed 1 month ago

jwise commented 1 month ago

When I am working with a scope at the front panel, I am used to being able to tweak parameters all from the waveform view screen (which, notably, is the entire screen!). The ngscopeclient metaphor of 'filter graph controls waveform' is nonintuitive to that usage of a scope, and it would be nice to be able to modify parameters (and display them, perhaps), from the Waveform Group window. For instance, compare the following two views of a DHO4000:

image

image

The DHO4000 front panel view shows the timebase parameters (4 GSa/s, 50Mpts capture = 250 ns/pt), and some information (but, arguably, not terribly high quality information) about the vertical parameters (offset of -5.20V is good information; DC is good information; "93.75 mV/div" is less useful than "750 mV full scale" would be in terms of telling me how much precision I am getting), as well as information about the trigger configuration. More to the point, I can change those without leaving the window on the DHO4000 by tapping on 'CH1' or turning the knob.

It would be nice for ngscopeclient to be able to show and edit these parameters. I can edit the timebase by going to Setup -> Timebase, but to edit the vertical configuration, I must go to Filter Graph and right click on Chan1.

It seems to me like one 'obvious' place for this to be would be in the Stream Browser: in the expanded view of 'dho4000' there could be blocks that provide timebase/trigger status (double click to edit numerically and precisely), and in the expanded view of CHAN1 there could be a block that provides vertical parameters (also double click to edit numerically and precisely). I am not sure what the Stream Browser is usually used for, but at least in the default configuration with a single instrument, this seems like it would be a good use of this space.

jwise commented 1 month ago

Fixed by #765 .