search

ngscopeclient / scopehal

Test and measurement hardware abstraction library and protocol decodes. This is the library only. Most users should use scopehal-apps.
BSD 3-Clause "New" or "Revised" License
216 stars 97 forks source link

Regression: all Ethernet protocol decodes crash #704

Closed azonenberg closed 2 years ago

azonenberg commented 2 years ago

Likely due to how AcceleratorBuffer handles (not at all) non-POD datatypes.

Simplest fix is probably for EthernetFrameSegment to not use a std::vector.

azonenberg commented 2 years ago

Fixed in 42791c6 by making AcceleratorBuffer construct/destruct non-POD datatypes properly in CPU-only buffers.

Long term, to enable GPU based decodes etc, we should try to convert EthernetFrameSegment to a POD type with a fixed size data field.