ngscopeclient / scopehal

Test and measurement hardware abstraction library and protocol decodes. This is the library only. Most users should use scopehal-apps.
BSD 3-Clause "New" or "Revised" License
216 stars 97 forks source link

Remove usages of non-portable functions/headers #711

Closed ehntoo closed 2 years ago

ehntoo commented 2 years ago

Several places in the codebase make use of POSIX headers and functions (e.g. unistd.h, fcntl.h, and dirent.h). These will make a straight windows port more difficult and should be removed.

An incomplete list:

azonenberg commented 2 years ago

SCPITMCTransport should be entirely ifdef'd in its current form; it relies on the Linux /dev/usbtmc kernel driver and is not usable on any other platform.

See #519.

azonenberg commented 2 years ago

SCPINullTransport does not even call any functions from these headers, likely copy-paste bug. So that's trivial to remove.