Make color a per-stream property rather than per channel

ngscopeclient / scopehal

Test and measurement hardware abstraction library and protocol decodes. This is the library only. Most users should use scopehal-apps.

BSD 3-Clause "New" or "Revised" License

216 stars 97 forks source link

Make color a per-stream property rather than per channel #736

Open bvernoux opened 2 years ago

bvernoux commented 2 years ago

ngscopeclient import bin with multiple channel shall have their own colors During import of bin (it is probably the same for other import with multiple channel) there is only one color for all channels Improvement:

Add one color R/G/B per channel instead of a global color R/G/B for all channels

Example of today import with 3 channels on a bin file (with all the same colors which is quite confusing and hard to use)

azonenberg commented 2 years ago

Moving to scopehal as this is an API issue.

azonenberg commented 2 years ago

The implementation of this is straightforward, the UI side is more of an open question.

The channel color is used in, for example, the filter graph editor to distinguish filters from each other. We also do want to allow related channels to be visually tied together (e.g. mag and angle of the same S-parameter import).

bvernoux commented 2 years ago

Having RGB color for each stream seems the best in worst case all color will be identical and that will work for all cases