SCPITMCTransport: fix usbtmc reads if driver workaround is not present

ngscopeclient / scopehal

Test and measurement hardware abstraction library and protocol decodes. This is the library only. Most users should use scopehal-apps.

BSD 3-Clause "New" or "Revised" License

216 stars 97 forks source link

SCPITMCTransport: fix usbtmc reads if driver workaround is not present #753

Closed Stary2001 closed 1 year ago

Stary2001 commented 1 year ago

Just a missing else. Rigol DS1054Z still doesn't work like this properly, but that's hopefully a different issue.

Before:

[stary@glados build]$ ./src/glscopeclient/glscopeclient rigol:rigol:usbtmc:/dev/usbtmc0
Warning: Bad IDN response  
Warning: Bad IDN response  
Warning: Bad IDN response  
ERROR: Persistent bad IDN response, giving up
ERROR: Bad model number
Segmentation fault (core dumped)

After: No errors.

Stary2001 commented 1 year ago

superseded by 7a14597cd0568d6fac4dd71e91fbfa1816894611