search

ngscopeclient / scopehal

Test and measurement hardware abstraction library and protocol decodes. This is the library only. Most users should use scopehal-apps.
BSD 3-Clause "New" or "Revised" License
216 stars 97 forks source link

Bug in USBTMC transport: `else` missing #754

Closed CodingMarco closed 1 year ago

CodingMarco commented 1 year ago

See: https://github.com/glscopeclient/scopehal/blob/e3fb92510a07f40565ba507046d728cdad0deb22/scopehal/SCPITMCTransport.cpp#L198-L207

the else seems to be missing, thus the read() is executed twice which lets the whole thing fail.

azonenberg commented 1 year ago

I don't have one of the buggy Siglent firmwares handy to know if this is a bug or if it's a workaround for #652.

@mandl can you have a look?

mandl commented 1 year ago

Hello Andrew, he ist right. The else is Missing. Please merge the pull requests. Thanks for reporting.

Andrew Zonenberg @.***> schrieb am So., 12. März 2023, 12:05:

I don't have one of the buggy Siglent firmwares handy to know if this is a bug or if it's a workaround for #652 https://github.com/glscopeclient/scopehal/issues/652.

@mandl https://github.com/mandl can you have a look?

— Reply to this email directly, view it on GitHub https://github.com/glscopeclient/scopehal/issues/754#issuecomment-1465275534, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAER3437C6FYBTVSWHAZAL3W3YUCLANCNFSM6AAAAAAVYI4OPU . You are receiving this because you were mentioned.Message ID: @.***>