Closed fredzo closed 2 weeks ago
Fred the hero of us poor(ly equipped in the T&M department)
Op zo 3 nov 2024 om 17:56 schreef fredzo @.***>:
Hi Andrew,
This one adds a driver for the tinySA and tinySA ULTRA Spectrum Analyzers. As these devices use UART over USB to communicate, I also added download progress support to SCPIUARTTransport class. I also created a SCPISA base class that can be derived for other specan only instrument drivers. Here is what it looks like: ngscopeclient_sTUtLS0JIe.gif (view on web) https://github.com/user-attachments/assets/09fb7691-dfca-473d-9f46-4e9a49a5f19d It goes with a compagnon PR for documentation.
Best,
Frederic.
You can view, comment on, or merge this pull request online at:
https://github.com/ngscopeclient/scopehal/pull/932 Commit Summary
- b78f4e0 https://github.com/ngscopeclient/scopehal/pull/932/commits/b78f4e0794a528fd087b09176128f46bc3e00ecf Fist step to TinySA driver
- 659b3df https://github.com/ngscopeclient/scopehal/pull/932/commits/659b3dffdb2f0daa1f2eec0defec611b7b399bb0 Added progress support to SCPIUARTTransport ReadRawData method.
- 7397dd4 https://github.com/ngscopeclient/scopehal/pull/932/commits/7397dd4424a0733d50642729099f0af851658d02 Added read timeout.
- a378ac8 https://github.com/ngscopeclient/scopehal/pull/932/commits/a378ac8a1b4bc776275e4d4563da554160b336c2 Added sweep boudnaries checks from device.
- 49efcf3 https://github.com/ngscopeclient/scopehal/pull/932/commits/49efcf387f2746b35cb1fb9eb5644b4e0ef0b96a Removed unnecessary lock
- 80e473a https://github.com/ngscopeclient/scopehal/pull/932/commits/80e473a72ca28dff8a8dcd5a4d28d82685d6bea7 Fixed returned sample rate value.
- ca965f2 https://github.com/ngscopeclient/scopehal/pull/932/commits/ca965f2d8a8e0170affc5f545ae609559ccfdd63 Fixed rbw handling.
- 66df270 https://github.com/ngscopeclient/scopehal/pull/932/commits/66df270708778306aa31414f7d4183445a017813 Refactored code to move common logic to SCPISA class.
- cf51ec0 https://github.com/ngscopeclient/scopehal/pull/932/commits/cf51ec066059f5a4455da9b5c8cf914b2ba27d2c Fixed comments
- 108ecd4 https://github.com/ngscopeclient/scopehal/pull/932/commits/108ecd42c7e5dd0427291fd4fa81e0391ffcf772 Fixed download for small memory depth.
File Changes
(8 files https://github.com/ngscopeclient/scopehal/pull/932/files)
- M scopehal/CMakeLists.txt https://github.com/ngscopeclient/scopehal/pull/932/files#diff-0c1fc4781215d8612038a1668d272725fc7f805904755eeeae35a22f2ed5af9c (2)
- A scopehal/SCPISA.cpp https://github.com/ngscopeclient/scopehal/pull/932/files#diff-ce42f7b3d334ee7177a0f4ca212bef59c89fd42626242f4aa979c652c785212b (311)
- A scopehal/SCPISA.h https://github.com/ngscopeclient/scopehal/pull/932/files#diff-6849984418686d7f3f4db02e6bfb30b7d1eb42b1d93af0fff27d99f6333dafa3 (133)
- M scopehal/SCPIUARTTransport.cpp https://github.com/ngscopeclient/scopehal/pull/932/files#diff-0dce3b2e50bd6a8ccf69f34220b17120d4cd405d13183217ac5c91eaca1d513e (29)
- A scopehal/TinySA.cpp https://github.com/ngscopeclient/scopehal/pull/932/files#diff-66691d98ae1515e0fb9fecb8ff609c5cf08501b48d06265e4182277563860c99 (540)
- A scopehal/TinySA.h https://github.com/ngscopeclient/scopehal/pull/932/files#diff-8971ba35e1649e582f5c47b849bd1ae042559d3d0074612b082261f861227a38 (128)
- M scopehal/scopehal.cpp https://github.com/ngscopeclient/scopehal/pull/932/files#diff-0736a868e651cca681fe35034f539d9a3412704c632f3032a2e6d580a6773554 (2)
- M scopehal/scopehal.h https://github.com/ngscopeclient/scopehal/pull/932/files#diff-a03af30dcf2a9b57547c642b630b233ea6489de0bf643e04eda1b8026c9f8d9c (1)
Patch Links:
- https://github.com/ngscopeclient/scopehal/pull/932.patch
- https://github.com/ngscopeclient/scopehal/pull/932.diff
— Reply to this email directly, view it on GitHub https://github.com/ngscopeclient/scopehal/pull/932, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEDD42H7JA4WWWJPI4BJBLZ6ZITFAVCNFSM6AAAAABRC4VUFCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGYZTCMZTGAZTOMI . You are receiving this because you are subscribed to this thread.Message ID: @.***>
Hi Andrew,
This one adds a driver for the tinySA and tinySA ULTRA Spectrum Analyzers. As these devices use UART over USB to communicate, I also added download progress support to SCPIUARTTransport class. I also created a SCPISA base class that can be derived for other specan only instrument drivers. Here is what it looks like: It goes with a compagnon PR for documentation.
Best,
Frederic.