search

ngscopeclient / scopehal

Test and measurement hardware abstraction library and protocol decodes. This is the library only. Most users should use scopehal-apps.
BSD 3-Clause "New" or "Revised" License
215 stars 96 forks source link

Question: Rigol oscilloscope driver refactoring #943

Open diggit opened 1 day ago

diggit commented 1 day ago

Hi, I have some WIP changes in Rigol oscilloscope driver. It implements sampling rate/memory depth settings, faster data readout (tested on DS1000Z and more) and possibly more changes. I ended up with the need to with distinguishing between each scope series, not just protocol versions (MS05, DS, DS_OLD,...) due to some properties being only for specific series. It is quite heavy refactor of the existing code.

I did these changes longer time ago, and they need porting to current code-base to be "upstreamable". I can test these changes on DS1000Z and possibly on MSO/DS2000A.

My question is, if such heavy refactoring, which could temporarily break support of some Rigol scopes, would be even considered for merging.

azonenberg commented 1 day ago

Yes, it would be considered although we'd want to get as many Rigol users as possible to test and fix issues with other scope families (e.g. MSO5000) before merging.

You have time, we're doing feature freeze for v0.1 end of month so we won't be taking new major PRs until after v0.1 releases unless they're bug fixes, documentation, or OS packaging related.