search

nguillaumin / slick2d-maven

Maven distribution of the Slick2D Gava game development library
BSD 3-Clause "New" or "Revised" License
66 stars 37 forks source link

lifecycle copy-dependencies is not supported by m2e #3

Closed akiwarheit closed 11 years ago

akiwarheit commented 11 years ago

Love the project and I'm gonna help out as much as I can.

I use mainly Eclipse and m2e for dev stuff. I can file a pull request if you want :+1:

nguillaumin commented 11 years ago

Hi,

Happy to take a pull request, but only for the packaging stuff (Maven, etc.). The actual sources of slick2d are hosted elsewhere (https://bitbucket.org/kevglass/slick) and not maintained by me. In fact I'm a bit concerned as there were no commits since March on the actual source I believe...

Thanks,

Nico

akiwarheit commented 11 years ago

That is a bit concerning...

Anyways I've actually updated some parts of the poms, JDK 1.7 specific (jnlp.jar is now javaws.jar). Still having doubts if I should include that in the request.

I might start making tests too to make sure everything is in order. Anyway, good work on maintaining this :+1:

nguillaumin commented 11 years ago

Happy to take multiple pull requests, 1 per feature would be ideal to avoid confusion.

I'm surprised about jnlp.jar being renamed to javaws.jar. I'm using Java 1.7 and it's still jnlp.jar for me. javaws.jar is a different jar that as to do with web services I believe...

akiwarheit commented 11 years ago

Weird, I can't seem to resolve jnlp.jar, javaws.jar works though. I'll do some more reading on that... definitely a new issue.

nguillaumin commented 11 years ago

jnlp.jar is not available in the Maven repos due to licensing issues, however it is available as a separate download for Java 7 (See the readme, I'll update it to make that more clear). The pom.xml references jnlp.jar with a local path for that reason, rather than fetching it from the Maven repos.

nguillaumin commented 11 years ago

Fixed by pull request #4