search

ngulam-ai / Sherlock

0 stars 0 forks source link

Transformation and cleansing needed before storing in Bigquery | others... #14

Closed ngulamai closed 6 years ago

ngulamai commented 6 years ago

Similarly to the other cases, before writing to Bigquery please review all custom dimensions and replace with null (empty) whenever any of these entries is found:

akolchin-MM commented 6 years ago

@dchubiryaev Please apply this improvement

dchubiryaev commented 6 years ago

@ngulamai Hello! You have in CustomDimension "index": "1", "value": "Spain;Castilla-La Mancha;Fuentealbilla;unknown;unknown;Android;6.0.1;Mozilla/5.0 (Linux; Android 6.0.1; SAMSUNG SM-J500FN Build/MMB29M) AppleWebKit/537.36 (KHTML, like Gecko) SamsungBrowser/6.2 Chrome/56.0.2924.87 Mobile Safari/537.36;90.174.2.53;$$CUSTOM_PARAM(cd11)$$;$$CUSTOM_PARAM(cd7)$$;$$CUSTOM_PARAM(cd10)$$" Will I be need replacement too of strings $$CUSTOM_PARAM(cd11)$$;$$CUSTOM_PARAM(cd7)$$;$$CUSTOM_PARAM(cd10)$$" by null?

ngulamai commented 6 years ago

Hi Yes indeed, the case $$CUSTOM_PARAM(cd1)$$ falls into this use case

$$xxxxxxx$$: example: $$MOBILE_CARRIER$$, $$SERVE_DOMAIN$$, etc

On 30 Jan 2018, at 16:10, Danil notifications@github.com wrote:

@ngulamai https://github.com/ngulamai Hello! You has in CustomDimension "index": "1", "value": "Spain;Castilla-La Mancha;Fuentealbilla;unknown;unknown;Android;6.0.1;Mozilla/5.0 (Linux; Android 6.0.1; SAMSUNG SM-J500FN Build/MMB29M) AppleWebKit/537.36 (KHTML, like Gecko) SamsungBrowser/6.2 Chrome/56.0.2924.87 Mobile Safari/537.36;90.174.2.53;$$CUSTOM_PARAM(cd11)$$;$$CUSTOM_PARAM(cd7)$$;$$CUSTOM_PARAM(cd10)$$" Will I be need replacement too of strings $$CUSTOM_PARAM(cd11)$$;$$CUSTOM_PARAM(cd7)$$;$$CUSTOM_PARAM(cd10)$$" by null?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ngulam-ai/Sherlock/issues/14#issuecomment-361622718, or mute the thread https://github.com/notifications/unsubscribe-auth/AfvWTX3fRNt8CGJWeoADuGAu5ObxK5E2ks5tPzDKgaJpZM4RodOD.