[Android Bootcamp] Review Nina's Twitter v2 App

[nguo]

Please review my twitter v2 app. Thanks! Was busy this weekend with work so didn't get to make as many changes as I would've liked. /cc @nesquena @timothy1ee

Question:

1. Is there a library you would recommend that handles swiping left/right to switch between tabs?

Hours spent: 10

Optional stories I did:

• When a network request goes out, user sees an indeterminate progress indicator -- partial: only when retrieving tweets.
• User can "reply" to any tweet on their home timeline
• User can take favorite (and unfavorite) or reweet actions on a tweet -- partial: did the favorite/unfavorite part.
• Improve the user interface and theme the app to feel twitter branded -- worked on the top part of the profile activity.

[nesquena]

1. Is there a library you would recommend that handles swiping left/right to switch between tabs?

If you want to swipe between, the secret is using the ViewPager and a third party indicator strip. You should try it at some point :)

[nesquena]

:+1: excellent job Nina! It's a great starting twitter client, hope you feel this project was a good learning opportunity. A few notes after checking out the code:

• Nice to see you used a drawable and/or styles to customize the view
• For tabs, try following this approach for cleaner tab listeners and better memory management.
• Nice use of tag to setup the ability to click the profile image and view a user's profile
• Good to see you properly communicated the user to the user timeline fragment from the profile activity.
• Nicely done architecting the fragments (base class and extension classes) such that you put as much code and logic as possible in the base class and then used abstract methods to define only the specific behavior where they differ!

Here's a detailed Project 4 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you might be able to improve your submission.

This week (Week 5), we are going to cover the last major piece to the Android puzzle and that is using the hardware and SDK components such as the camera, photo gallery, location, maps, etc. After that, Week 6 and week 7 we will be covering a few important intermediate topics such as more about styling and animation as well as testing.

Following the bootcamp (May 12th), we are going to have a demo day to celebrate the progress you've all made with our next batch of Android students and multiple companies attending to see the group projects that you all have built. We are going to help however we can over the next few weeks to get the team project apps in shape for that.

Was busy this weekend with work so didn't get to make as many changes as I would've liked.

This is a great submission but hope you are able to circle back and apply the feedback and perhaps push forward this as time allows.