search

nguy / artview

ARM Radar Toolkit Viewer
http://nguy.github.io/artview
BSD 3-Clause "New" or "Revised" License
48 stars 21 forks source link

BUG: GateFilter plugin works on ndarray fields #123

Closed jjhelmus closed 8 years ago

jjhelmus commented 8 years ago

The GateFilter plugin works on radar volumes which contain fields where the data is stored as an ndarray not a MaskedArray object.

closes #121

jjhelmus commented 8 years ago

A NetCDF file which when read with Py-ART has a field whose data is an ndarray useful for testing. You will need to zoom in to see the data as the spatial extent of this data is ~ 1 km by 1 km.

gamaanderson commented 8 years ago

I think gatefilter.py is the only file I think this happens, but I'm not sure. Did you run a search to try to find it? If yes, then this would be good to merge @nguy.

Thank you @jjhelmus

jjhelmus commented 8 years ago

I searched through the code and found one other use of the mask attribute that might cause an issue. Fixed in 89f73a2. This should be good to go.

gamaanderson commented 8 years ago

I agree this is good to go. Please merge @nguy.

nguy commented 8 years ago

@jjhelmus this looks like a nice fix!

jjhelmus commented 8 years ago

Good catch @nguy, added the missing parenthesis.

nguy commented 8 years ago

@jjhelmus Great work! Any chance I could get you to change L373 from: common.ShowWarning("Radar is None, can not perform filtering.") to common.ShowWarning("Radar is None, cannot perform filtering.")?

I'll merge then.

jjhelmus commented 8 years ago

Done

nguy commented 8 years ago

Awesome, thanks again @jjhelmus ! Merging.