GSM alphanumeric escaped characters in originating address

nguyenbahuong / smslib

Automatically exported from code.google.com/p/smslib

0 stars 0 forks source link

GSM alphanumeric escaped characters in originating address #500

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

If the originating address is alphanumeric and contains escaped characters the 
calculation of the length of the resulting Java Unicode String is broken, as it 
assumes that each character in the originating address will correspond to 1 
character in the Java Unicode String.

Original issue reported on code.google.com by andrew.basterfield@dialogue.net on 17 Aug 2012 at 12:26

Attachments:

alpha-oa-escaped-characters.diff

GoogleCodeExporter commented 9 years ago

Can you have escaped chars in an alphanumeric originator address? Can you 
please give an example?

Original comment by admin@smslib.org on 19 Aug 2012 at 1:45

Changed state: Review

GoogleCodeExporter commented 9 years ago

See ETSI 03.40 section 9.1.25 "Address Fields" 
http://www.etsi.org/deliver/etsi_gts/03/0340/05.01.00_60/gsmts_0340v050100p.pdf

"Alphanumeric, (coded according to GSM TS 03.38 7-bit default alphabet)"

No mention of any exception for escaped characters.

Empirically all handsets we have tested support escaped characters in TP-OA. 
Tomorrow I will include an example PDU from our regression test case

Original comment by andrew.basterfield@dialogue.net on 19 Aug 2012 at 2:34

GoogleCodeExporter commented 9 years ago

Here is a PDU with an escaped character in the alpha originating address

07914477000000000414D0E10D6FE3DBA036A94D190000217050321314042030D82C2703B540F4F2
9C1E83815AA0A73C7D4EBBC3F4B71C442DCFE9

Original comment by andrew.basterfield@dialogue.net on 22 Aug 2012 at 8:11

GoogleCodeExporter commented 9 years ago

Thanks.

Original comment by admin@smslib.org on 22 Aug 2012 at 4:39

Changed state: Started
Added labels: Component-SMSLib, Milestone-v3.5.3, Priority-High

GoogleCodeExporter commented 9 years ago

The great thing about this patch is that it solves one of those crazy "Index 
out of bounds..." errors thrown by smslib :)

Original comment by admin@smslib.org on 22 Aug 2012 at 4:46

GoogleCodeExporter commented 9 years ago

r2346

Original comment by admin@smslib.org on 22 Aug 2012 at 4:48

Changed state: Completed

GoogleCodeExporter commented 9 years ago

Original comment by admin@smslib.org on 6 Mar 2013 at 9:27

Changed state: Fixed