SMPPGateway - TON & NPI - code bug

[GoogleCodeExporter]

Hi there just found a bug in the SMPPGateway - org.smslib.smsserver.gateways

create() and getBindAttributes()

The NPI where using the TON values, causing problems when the number doesnt 
exists in the NPI values. (EX: TON = 5, causes gateway error)

It's a classic Copy/Paste error.

Fix change in 3 places:

NumberingPlanIndicator 
numberingPlanIndicator=(npi==null)?NumberingPlanIndicator.UNKNOWN:NumberingPlanI
ndicator.valueOf(Byte.parseByte(ton));

to:

NumberingPlanIndicator 
numberingPlanIndicator=(npi==null)?NumberingPlanIndicator.UNKNOWN:NumberingPlanI
ndicator.valueOf(Byte.parseByte(npi));

Original issue reported on code.google.com by tiago.pe...@gmail.com on 3 Oct 2013 at 3:56

[GoogleCodeExporter]

Original comment by admin@smslib.org on 1 Jan 2014 at 9:25

• Changed state: Review

[GoogleCodeExporter]

https://github.com/smslib/smslib-v3/pull/2

Original comment by admin@smslib.org on 2 Jan 2014 at 12:06

• Changed state: Duplicate