search

nguyenchauchieu / nimble-survey

0 stars 0 forks source link

No SwiftLint code style warnings #4

Open edgarss opened 4 years ago

edgarss commented 4 years ago

A lot of places in the code would have triggered SwiftLint warnings about code style especially lines of code that go for 2-3 lines without breaks.

nguyenchauchieu commented 4 years ago

I integrate SwiftLint warnings into the project. Since SwiftLint has a lot of rules and fixing all of them is not necessary, do we have the coding convention of the team?

edgarss commented 4 years ago

using the default settings is fine and if something bothers you too much it can of course be turned off

nguyenchauchieu commented 4 years ago

I got it, thanks

edgarss commented 4 years ago

I dont seem to be able to build the project anymore after SwiftLint being added

Screenshot 2020-11-13 at 11 10 07
nguyenchauchieu commented 4 years ago

It is because of too many rules from SwiftLint. Some of them are major and marked as errors so you can not build the project. SwiftLint also checks the code from 3rd libraries. That is my concern in the previous comment. I will check if we can make SwiftLint ignore 3rd libraries and remove the unnecessary rules.