search

nguyenchr / atom-cargo-test-runner

Cargo test runner for Atom Editor
https://atom.io/packages/cargo-test-runner
MIT License
5 stars 3 forks source link

remove file name from cargo flags #15

Closed ferkulat closed 8 years ago

ferkulat commented 8 years ago

Hi nguyenchr,

I am just evaluating atom as my new rust IDE. But I really want to be able to run tests from it.

This small change fixed it for me:

if the cargo flags are just 'test' it works fine

with kind regards

ferkulat

nguyenchr commented 8 years ago

Hi @ferkulat Won't this remove the ability to run individual tests, and it will just run the entire suite?

From the cargo guide

You can also run a specific test by passing a filter:

$ cargo test foo

This will run any test with foo in its name.
ferkulat commented 8 years ago

Hi @nguyenchr ,

maybe this will remove the ability to run individual tests. But it will close Issue #4. without this fix when I press Alt-Ctrl-c, it runs the binary but spits out:

`Cargo binary: /usr/bin/cargo running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured ` In general when I do TDD, I want to run all tests after every change. Before being able to run individual tests, I would like to run all of them.

It looks like the implementation assumes, the files to test are named after the test cases . (?) This is not always the case. So just "cargo test" would do the job.

with kind regards

nguyenchr commented 8 years ago

yep good point 👍

nguyenchr commented 8 years ago

this fix is now in the latest v0.1.0 release, thanks for the help :)