nguyenduong / spritebuilder_cocos2dx

Sprite Builder lib for Cocos2-x
Other
80 stars 44 forks source link

incorrect contain logic in CCNodeLoader #14

Closed githubmin closed 10 years ago

githubmin commented 10 years ago

- incorrect line -

setProp &= extraPropsNames->containsObject(CCString::create(propertyName));

- should be -

bool foundProperty = false; SetIterator it; for( it = extraPropsNames->begin(); it != extraPropsNames->end(); ++it) { String _propName = (_String)*it; if (strcmp(propertyName.c_str(), propName->getCString()) == 0) { foundProperty = true; break; } }

fixed in the pull request :)

ghost commented 10 years ago

@githubmin Your fix does not compile btw

githubmin commented 10 years ago

I compiled it with cocos2d-x 3.2 final, is the version issue stop your compilation?

nguyenduong commented 10 years ago

Thanks. Fixed