search

nguyenhoanglam / ImagePicker

A customizable library for selecting images on the device.
Apache License 2.0
598 stars 158 forks source link

Added support for picking Videos #113

Closed andybdahl closed 4 years ago

andybdahl commented 4 years ago

I have added support for picking both Videos/Images. This is a breaking change, since all earlier Image types is now Asset types, with a new Asset "Video" added too. Works out of the box, and also updated the README to reflect the changes. Support for recording videos is also added, and is enabled when videos are included (via a flag) in the Config.

I updated the Sample app too, so you can test the result.

I suggest bumping the major to version 2.0.0, as all versions using 1.x would break with this change.

nguyenhoanglam commented 4 years ago

@andreasmakeable I really apprecicate your contribution to my library! However, at the moment, I'm so busy so that I don't have time to review and test your PR. I'll check it later and release new version if it works correctly.

Once again, thank you so much!

andybdahl commented 4 years ago

No problem, we needed support for picking videos as well as photos at work, and we've been using your library on the Android team here, so I added the video functionality directly to your library. Hope you can test it soon, until then I'll be using my own fork of the library.

andybdahl commented 4 years ago

Any updates on the testing process? @nguyenhoanglam ?

nguyenhoanglam commented 4 years ago

@andreasmakeable I'll begin to test the PR at this weekend. So please wait for some more days.