search

nguyenhoanglam / ImagePicker

A customizable library for selecting images on the device.
Apache License 2.0
598 stars 158 forks source link

Update Android Manifest #146

Open ssohaib opened 2 years ago

ssohaib commented 2 years ago

Source code require the android:exported="true" to run on Android 12, kindly update, thanks

nguyenhoanglam commented 2 years ago

@ssohaib I've run your PR on Android 12 and it crashes with java.lang.RuntimeException: Unable to get provider androidx.core.content.FileProvider: java.lang.SecurityException: Provider must not be exported. Have you tested it yet?

I think we have to keep android:exported="false" for Provider.

ssohaib commented 2 years ago

Brother can you plz find a way to make it work with Android 12, I am not very good at development.

On Sun, Aug 28, 2022, 8:32 PM Nguyen Hoang Lam @.***> wrote:

@ssohaib https://github.com/ssohaib I've run your PR on Android 12 and it crashes with java.lang.RuntimeException: Unable to get provider androidx.core.content.FileProvider: java.lang.SecurityException: Provider must not be exported. Have you tested it yet?

I think we have to keep android:exported="false" for Provider.

— Reply to this email directly, view it on GitHub https://github.com/nguyenhoanglam/ImagePicker/pull/146#issuecomment-1229486830, or unsubscribe https://github.com/notifications/unsubscribe-auth/AATSUH56YZBNXUXHYQRHGPLV3OBBDANCNFSM572K7ALA . You are receiving this because you were mentioned.Message ID: @.***>

nguyenhoanglam commented 2 years ago

I run it on android 12 emulator and it works fine. What's your issue with android 12?