search

nguyenmp / bisque

An Android client for https://lobste.rs/
MIT License
1 stars 0 forks source link

Add support for hiding comments #11

Closed nguyenmp closed 9 years ago

nguyenmp commented 9 years ago

Tapping a comment to hide its children seems reasonable. Then we'll have action buttons on the bottom right or a contextual popup button on the top right.

nguyenmp commented 9 years ago

This and #12 will probably need some update to chowders. Currently, the comments and the post are too tightly coupled using inheritance. Although this is how the API presents it to us, I believe we should use composition. A story is really a post with a list of comments. This doesn't afford for us to have metadata for comments and posts individually, the way I had originally designed the database.

There's a couple of things we can do:

  1. Redesign the database to afford for this structure. I don't really see any good easy way of doing this.
  2. Have a wrapper that contains a post and a list of comments instead of the way we have stories at the moment. Then, we can have a metadata wrapper which contains a metadata post and a list of metadata comments. i think this can be reasonable but is more involved.
  3. I don't really have any other alternatives.... :(
nguyenmp commented 9 years ago

Implemented in 04e27b4b0e369269b67970db95ac2544d4cb5f62 and acd02ad316138dd084bac8b8af9b372b5a80e4f6.