There's some horrifying crashes on ask stories

nguyenmp / bisque

An Android client for https://lobste.rs/

MIT License

1 stars 0 forks source link

There's some horrifying crashes on ask stories #13

Closed nguyenmp closed 9 years ago

nguyenmp commented 9 years ago

Basically, there's a lot of null checks that we don't perform. Sharing an ask thread should share comments, not post.

nguyenmp commented 9 years ago

This was primarily fixed in bfc1cb3f777c1109394e1711e6b85f9cb831620b.

The issue was that we were binding the controllers and the webview before we got any data. When we finally got the data, these bindings were never updated. This fixed the bindings for the controller for each update to the data. We bound the webview only if it has not been bound before.