search

nguyenngoclongdev / vs-terminal-keeper

Easily save and recall previous terminal sessions, create new sessions, and edit or delete existing ones.
https://marketplace.visualstudio.com/items?itemName=nguyenngoclong.terminal-keeper
MIT License
18 stars 2 forks source link

Terminal Keeper: Killing previous terminals... #12

Closed Downlord closed 3 months ago

Downlord commented 5 months ago

Describe the bug Terminal Keeper Plugin will not start and a notification is showing: "Terminal Keeper: Killing previous terminals..."

To Reproduce I don't know how to reproduce, in my VSC Instance it keeps showing every time i Start VSC on a remote Server using Remote SSH

Expected behavior It would be nice to know, how to resolve this. Either by manually killing the process or by cleaning up the file letting the Plugin believe it needs to terminate "previous terminals" I tried to clean up the processes on the remote VM by killing all vscode instances, but somehow the plugin thinks re are terminal that have to be terminated

X52p commented 4 months ago

I encountered the same problem, also using Remote SSH. It started after a recent VSC update.

Possible workaround: For me, setting "keepExistingTerminals": true, got it working again. (I assume "Killing previous terminals" is not executed in that case).

VinhNgT commented 4 months ago

Me too, but mine happens when there's more than 1 folder in the workspace:

Example:

Only the .vscode of Folder 1 has sessions.json

tcdent commented 4 months ago

"keepExistingTerminals":"false" got it working again for me, too.

Something changed a version or two ago in VSCode that created this bug.

nguyenngoclongdev commented 3 months ago

@Downlord Thank you for your feedback. As you stated, this error seems to have arisen during the recent update of Visual Studio Code (VSCode). This is because I used the command "workbench.action.terminal.killAll" to quickly kill the previous terminals. However, there is a change in VSCode's API that makes this command become stuck. I have tried using another method to kill all terminals in the "v1.1.16" update. Please try the new method and let me know if you encounter any errors.

cc: @X52p @VinhNgT @tcdent