nguyenngoclongdev / vs-terminal-keeper

Easily save and recall previous terminal sessions, create new sessions, and edit or delete existing ones.
https://marketplace.visualstudio.com/items?itemName=nguyenngoclong.terminal-keeper
MIT License
13 stars 0 forks source link

Icons doesnt func in MAC #2

Closed Bryan-Herrera-DEV closed 11 months ago

Bryan-Herrera-DEV commented 11 months ago

Describe the bug Icons not activate in mac but in windows no problem

To Reproduce

image image

Expected behavior

Platform:

nguyenngoclongdev commented 11 months ago

@Bryan-Herrera-DEV Thank for reporting.

I also use macOS, and this extension was developed on it. The icon on my machine displays normally.

However, I will try to investigate this issue. It would be helpful if you could provide me with more information, such as your macOS version and the terminal you are using (bash or zsh).

Bryan-Herrera-DEV commented 11 months ago

Im using zsh to show terminal, I'm starting to believe that maybe it's the configuration of the environment, although I still doubt that my Windows machine works fine

nguyenngoclongdev commented 11 months ago

After investigating, it seems that this issue is caused by a VS Code API. I have noticed that there are quite a few reports on issues with using the VS Code API, not only regarding incorrect icon behavior but also similar issues with colors.

https://github.com/microsoft/vscode/issues/171082 https://github.com/microsoft/vscode/issues/167643 https://github.com/VSCodeTriageBot/testissues/issues/15028

There is a temporary solution to fix this issue, which is to configure the shellPath on each terminal setting. Some users have configured the shellPath on each terminal setting, and have reported that the icon and color display correctly. I am not sure if it works, but you can try it out.

For example:

{
    "$schema": "https://cdn.statically.io/gh/nguyenngoclongdev/cdn/main/schema/v7/terminal-keeper.json",
    "theme": "tribe",
    "active": "default",
    "activateOnStartup": false,
    "keepExistingTerminals": false,
    "sessions": {
        "default": [
            [
                {
                    "name": "ssh:ubuntu",
                    "shellPath": "/usr/local/bin/zsh", // 👈 add this line
                    "commands": [
                        "echo hello1"
                    ]
                },
                {
                    "name": "ssh:mint",
                    "shellPath": "/usr/local/bin/zsh", // 👈 add this line
                    "commands": [
                        "echo hello2"
                    ]
                },
                {
                    "name": "ssh:macos",
                    "shellPath": "/usr/local/bin/zsh", // 👈 add this line
                    "commands": [
                        "echo hello3"
                    ]
                },
                {
                    "name": "ssh:windows",
                    "shellPath": "/usr/local/bin/zsh", // 👈 add this line
                    "commands": [
                        "echo hello4"
                    ]
                }
            ]
        ]
    }
}

Use which zsh to get the path of the zsh shell on your machine.