search

nguyenpham / ocgdb

Open Chess Game Database Standard (OCGDB)
MIT License
31 stars 8 forks source link

Base.cpp code defect #32

Closed dcorbit closed 2 years ago

dcorbit commented 2 years ago 
    Hist tmphist;
    if (!commentMap.empty()) {
        auto it = commentMap.find(i + 1);
        if (it != commentMap.end()) {
            if (flag & ParseMoveListFlag_parseComment) {
                _parseComment(it->second, tmphist);
            } else {
                if (!tmphist.comment.empty()) {
                    tmphist.comment + ", "; // SURELY THIS SHOULD BE += rather than + which has no effect
                }
                tmphist.comment += it->second;
            }
            hasComment = true;
        }
nguyenpham commented 2 years ago

Thank Dann, The bug is fixed with the commit https://github.com/nguyenpham/ocgdb/commit/15d20caf57f4fd8e1bbbdfc2182108271e3c8fc1